Skip to content

HYPERFLEET-1094 - ci: add /licenses to container image#157

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1094-add-licenses
May 15, 2026
Merged

HYPERFLEET-1094 - ci: add /licenses to container image#157
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1094-add-licenses

Conversation

@ciaranRoche
Copy link
Copy Markdown
Contributor

@ciaranRoche ciaranRoche commented May 15, 2026

Summary

  • Copies LICENSE into /licenses/ in the container image for Konflux preflight HasLicense certification check

Test plan

  • Konflux preflight HasLicense check passes
  • No regression in other preflight checks

🤖 Generated with Claude Code

@openshift-ci openshift-ci Bot requested review from jsell-rh and rafabene May 15, 2026 11:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 54463b5a-b2bf-418a-afd3-0afcc0526f50

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0df56 and 776aba7.

📒 Files selected for processing (2)
  • .dockerignore
  • Dockerfile
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Included the project license file in the final runtime image; the license artifact is now part of the packaged runtime layer for released images.
    • Simplified the image build ignore configuration header related to ownership/licensing entries, removing a redundant ignore entry and clarifying the header comment for that section.

Walkthrough

The Dockerfile is updated to copy the built LICENSE file from the builder stage into the runtime image at /licenses/LICENSE. This adds one new COPY --from=builder instruction in the final stage, ensuring the license file is included in the distributed container image. No other build steps or runtime behavior is modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding licenses to the container image for Konflux preflight certification.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose and providing a test plan for the license directory addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1094-add-licenses

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Comment @coderabbitai help to get the list of available commands and usage tips.

@ciaranRoche
Copy link
Copy Markdown
Contributor Author

ciaranRoche commented May 15, 2026

/test presubmits-integration

@ciaranRoche
Copy link
Copy Markdown
Contributor Author

ciaranRoche commented May 15, 2026

/retest

@ciaranRoche ciaranRoche force-pushed the HYPERFLEET-1094-add-licenses branch from 00555cd to 7a0df56 Compare May 15, 2026 11:46
@ciaranRoche @claude
HYPERFLEET-1094 - ci: add /licenses to container image
776aba7 
Co-Authored-By: Claude <noreply@anthropic.com>
@ciaranRoche ciaranRoche force-pushed the HYPERFLEET-1094-add-licenses branch from 7a0df56 to 776aba7 Compare May 15, 2026 11:48
@rafabene
Copy link
Copy Markdown
Contributor

rafabene commented May 15, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f80ef4e into main May 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsell-rh jsell-rh Awaiting requested review from jsell-rh

@rafabene rafabene Awaiting requested review from rafabene

Assignees

@rafabene rafabene

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ciaranRoche @rafabene